Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement from_be_bytes/from_le_bytes for Uint64 and Uint128 (backport #2351) #2353

Closed
wants to merge 4 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025

Closes #2269

We could use a similar macro for the larger types based on bnum, but that would be a lot of extra work that does not provide an immediate benefit. I'd do that later maybe but in a separate PR.


This is an automatic backport of pull request #2351 done by Mergify.

(cherry picked from commit 73dd089)

# Conflicts:
#	packages/std/src/math/int128.rs
#	packages/std/src/math/int64.rs
(cherry picked from commit 23de2fc)

# Conflicts:
#	CHANGELOG.md
#	packages/std/src/math/uint128.rs
#	packages/std/src/math/uint64.rs
@mergify mergify bot added the conflicts label Jan 29, 2025
Copy link
Contributor Author

mergify bot commented Jan 29, 2025

Cherry-pick of 73dd089 has failed:

On branch mergify/bp/release/2.2/pr-2351
Your branch is ahead of 'origin/release/2.2' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 73dd0892.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   packages/std/src/math/conversion.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   packages/std/src/math/int128.rs
	both modified:   packages/std/src/math/int64.rs

Cherry-pick of 23de2fc has failed:

On branch mergify/bp/release/2.2/pr-2351
Your branch is ahead of 'origin/release/2.2' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 23de2fcd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   packages/std/src/math/uint128.rs
	both modified:   packages/std/src/math/uint64.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@webmaster128 webmaster128 deleted the mergify/bp/release/2.2/pr-2351 branch January 30, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant