Implement from_be_bytes/from_le_bytes for Uint64 and Uint128 #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport release/2.2 |
✅ Backports have been created
|
|
@mergify backport release/2.2 |
✅ Backports have been created
|
|
@mergify backport release/2.2 |
✅ Backports have been created
|
|
Manual backport here: #2360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2269
We could use a similar macro for the larger types based on bnum, but that would be a lot of extra work that does not provide an immediate benefit. I'd do that later maybe but in a separate PR.