Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include locales files in production #481

Merged
merged 20 commits into from
Jan 17, 2025
Merged

feat: include locales files in production #481

merged 20 commits into from
Jan 17, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Jan 14, 2025

This PR is to add locales/*.json in the npm package so that language loading works on production.

BEGIN_COMMIT_OVERRIDE

chore: add locales/*.json in the npm package so that language loading works on production.

END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner January 14, 2025 12:06
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team January 14, 2025 12:06
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/sf-761 to main January 16, 2025 13:30
@khanti42 khanti42 dismissed stanleyyconsensys’s stale review January 16, 2025 13:30

The base branch was changed.

@khanti42 khanti42 enabled auto-merge January 16, 2025 13:50
@khanti42 khanti42 disabled auto-merge January 16, 2025 13:50
@khanti42 khanti42 enabled auto-merge January 16, 2025 13:50
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit d1da20f Jan 17, 2025
14 checks passed
@khanti42 khanti42 deleted the feat/sf-760 branch January 17, 2025 01:01
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants