Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet-ui translation #495

Merged
merged 19 commits into from
Jan 28, 2025
Merged

feat: wallet-ui translation #495

merged 19 commits into from
Jan 28, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Jan 23, 2025 •
edited by stanleyyconsensys
Loading

Adds translation to the wallet-ui for French and English.

note: the rpc methods needs to be restricted to the only information required.

BEGIN_COMMIT_OVERRIDE

feat: Enable multiple languages (FR) to support in SNAP and Wallet UI (#495, #481)

END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner January 23, 2025 20:06
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team January 23, 2025 20:06
stanleyyconsensys
stanleyyconsensys requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the solution create some memory leak,

and UI is different with SNAP, we should not use the same way that we did for SNAP

packages/starknet-snap/src/index.tsx Outdated Show resolved Hide resolved
packages/wallet-ui/src/assets/locales/en.json Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Show resolved Hide resolved
packages/wallet-ui/src/components/pages/Home/Home.view.tsx Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
stanleyyconsensys
stanleyyconsensys reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work to use Redux

but just feel the naming is a bit weird

setLanguage
setLocale

may be it should rename to

setLanguage -> setLocale
setLocale -> setTranslation

WDYT?

and also left some comments below

packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useStarkNetSnap.ts Outdated Show resolved Hide resolved
packages/wallet-ui/src/services/useMultiLanguage.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

stanleyyconsensys
stanleyyconsensys approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit comment, but i give a pass first

packages/wallet-ui/src/components/ui/organism/DeployModal/DeployModal.view.tsx Show resolved Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx Show resolved Hide resolved
packages/wallet-ui/src/components/ui/organism/UpgradeModel/UpgradeModel.view.tsx Show resolved Hide resolved
@khanti42
Copy link
Collaborator Author

solving comments in a fix pr

@khanti42 khanti42 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit ece4e17 Jan 28, 2025
14 checks passed
@khanti42 khanti42 deleted the feat/wallet-ui-translation branch January 28, 2025 15:16
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys