Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 24.04: Implement rule 5.3.3.1.2 Ensure password unlock time is configured #12772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ubuntu 24.04: Implement rule 5.3.3.1.2 Ensure password unlock time is configured #12772

wants to merge 2 commits into from

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Implement rule 5.3.3.1.2 Ensure password unlock time is configured

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.3.3.1.2

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 2, 2025 17:41
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 2, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Jan 6, 2025
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 6, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 6, 2025
mpurg
mpurg suggested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed

controls/cis_ubuntu2404.yml Outdated
notes: TODO. Rule does not seem to be implemented, nor does it map to any rules in ubuntu2204 profile.
status: automated
rules:
- var_accounts_passwords_pam_faillock_unlock_time=600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlock time should be 900

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alanmcanonical alanmcanonical mentioned this pull request Jan 9, 2025
Merged
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 10, 2025

Code Climate has analyzed commit ed08bce and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@mpurg
Copy link
Contributor

mpurg commented Jan 10, 2025

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpurg mpurg mpurg requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
3 participants
@alanmcanonical @mpurg @dodys