Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ctest of python-unit-utils/oscal #12796

Merged

Conversation

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 9, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@alanmcanonical alanmcanonical force-pushed the fix_ci_dependency branch 2 times, most recently from 417481f to 8598fea Compare January 9, 2025 13:39
@Mab879
Copy link
Member

Mab879 commented Jan 9, 2025

@jpower432 Is there any issues with us upgrading to the latest version of Trestle?

Copy link

codeclimate bot commented Jan 9, 2025

Code Climate has analyzed commit 9452e26 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.76 milestone Jan 9, 2025
@jpower432
Copy link
Contributor

@jpower432 Is there any issues with us upgrading to the latest version of Trestle?

@Mab879 I don't see any issues with upgrading. The update to v3 includes changes to the OSCAL Python classes in trestle, but no breaking changes with OSCAL itself (OSCAL 1.0.4 -> OSCAL 1.1.2).

@Mab879
Copy link
Member

Mab879 commented Jan 9, 2025

/packit retest-failed

2 similar comments
@Mab879
Copy link
Member

Mab879 commented Jan 9, 2025

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Jan 10, 2025

/packit retest-failed

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also reviewed a similar PR #12762

@marcusburghardt
Copy link
Member

Thanks for working on this @alanmcanonical @Mab879 and @jpower432 . I just reviewed a similar PR #12762 but that one is not enough to make CI tests green. So, I will prioritize this and monitor the CI tests along this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants