-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ctest of python-unit-utils/oscal #12796
Fix the ctest of python-unit-utils/oscal #12796
Conversation
…estle version in requirement
Hi @alanmcanonical. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ea929fa
to
dfcf292
Compare
417481f
to
8598fea
Compare
8598fea
to
9452e26
Compare
@jpower432 Is there any issues with us upgrading to the latest version of Trestle? |
Code Climate has analyzed commit 9452e26 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (0.0% change). View more on Code Climate. |
@Mab879 I don't see any issues with upgrading. The update to v3 includes changes to the OSCAL Python classes in trestle, but no breaking changes with OSCAL itself (OSCAL 1.0.4 -> OSCAL 1.1.2). |
/packit retest-failed |
2 similar comments
/packit retest-failed |
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also reviewed a similar PR #12762
Thanks for working on this @alanmcanonical @Mab879 and @jpower432 . I just reviewed a similar PR #12762 but that one is not enough to make CI tests green. So, I will prioritize this and monitor the CI tests along this morning. |
14ea4b7
into
ComplianceAsCode:master
Description:
Rationale:
python-unit-utils/oscal
fails on Ubuntu 24.04 #12795 and several workflow failures of Minor typo fix #12785 Ubuntu 24.04: Implement rule 5.3.3.3.1 Ensure password history remember is configured #12784 Ubuntu 24.04: Implement rule 5.3.3.4.2 Ensure pam_unix does not include remember #12780 Ubuntu 24.04: Implement rule 5.3.2.2 Ensure pam_faillock module is enabled #12779 Ubuntu 24.04: Implement rule 5.4.2.2 Ensure root is the only GID 0 account #12777 Ubuntu 24.04: Implement rule 5.3.3.1.2 Ensure password unlock time is configured #12772 Ubuntu 24.04: Implement 5.3.3.4.1 Ensure pam_unix does not include nullok #12770