-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Git Features and Navigator UI Improvements #1471
Conversation
CodeEdit/Features/NavigatorArea/SourceControlNavigator/SourceControlNavigatorView.swift
Outdated
Show resolved
Hide resolved
Great PR! |
03785d9
to
31e58d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a partial review, I'll be able to review the rest of the UI improvements later.
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager.swift
Outdated
Show resolved
Hide resolved
...vigatorArea/SourceControlNavigator/Views/Changes/SourceControlNavigatorChangedFileView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing the UI stuff. There's a couple UX papercuts in the git panes that I left notes about.
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorForm.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorForm.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorForm.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorForm.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorForm.swift
Outdated
Show resolved
Hide resolved
...vigatorArea/SourceControlNavigator/Views/Changes/SourceControlNavigatorChangedFileView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/SourceControlNavigator/SourceControlNavigatorView.swift
Outdated
Show resolved
Hide resolved
...rArea/SourceControlNavigator/Views/Repositories/SourceControlNavigatorRepositoriesView.swift
Outdated
Show resolved
Hide resolved
While testing this, I discovered that some of the source control UI looks a little off when @Wouter01's new windowing system feature flag is turned on. There is no padding in some areas and the list item size is way to big. Nothing I do seems to have any effect on it. Does anyone have any idea why this is? |
…or by replacing some text fields. Added more functionality to Find navigator's UI.
…nctionality to Find Navigator UI.
…aneTextField in navigators. Still a WIP. Crash occurs in changes tab of source control navigator because of duplicate keys of type 'CEWorkspaceFile'
…an now click a changed file to open it as a temporary tab in the editor, double-click to open as a normal tab.
…mmand. Checked state is synced with staged git status even when stage occurs externally.
…rce control navigator displays a content unavailable state letting the user know it isn't and offering an option to do a git init.
… text we were each manually styling.
…trolManager as an EnvironmentObject instead of passing it down the view hierarchy
…ult in Settings sidebar navigation list.
711ee8d
to
2c61453
Compare
...gatorArea/SourceControlNavigator/Changes/Views/SourceControlNavigatorChangesCommitView.swift
Outdated
Show resolved
Hide resolved
...gatorArea/SourceControlNavigator/Changes/Views/SourceControlNavigatorChangesCommitView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Improving the navigator and giving the UI design a bit more polish. See details below.
Checklist
Explore if using a text field style instead of a few for text fields are possible (see it here)Not a viable solutionUse pickers instead of menus for breadcrumb pickers(will do in a separate PR)CEContentUnavailableView
) for our zero-states (currently each are individually styled - not very DRY)VStack
)Display changes list as tree(will do in another PR)Combine checkboxes and M/A/D/? into toggle-able icons to the right(decided that checkboxes are more clear)Screenshots
Screen.Recording.2023-11-02.at.10.23.06.AM.mov
Screen.Recording.2023-11-13.at.9.07.07.PM.mov
Screen.Recording.2023-11-18.at.1.50.57.AM.mp4
Screen.Recording.2023-11-18.at.3.12.31.AM.mp4
Screen.Recording.2023-11-19.at.12.41.43.AM.mp4