Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: points rework (v1) #1663

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
+2,023 −2,563

partially migrate to new graph system and fix cpu bug

12f831b
Select commit
Loading
Failed to load commit list.
Draft

refactor: points rework (v1) #1663

partially migrate to new graph system and fix cpu bug
12f831b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 26, 2025 in 0s

54.11% (+0.16%) compared to cf91c73

View this Pull Request on Codecov

54.11% (+0.16%) compared to cf91c73

Details

Codecov Report

Attention: Patch coverage is 59.28237% with 522 lines in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (cf91c73) to head (12f831b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/canvas/widgets/network_graph.rs 61.73% 88 Missing ⚠️
src/canvas/widgets/cpu_basic.rs 0.00% 83 Missing ⚠️
src/app/data/time_series.rs 35.24% 79 Missing ⚠️
src/canvas/widgets/mem_basic.rs 0.00% 67 Missing ⚠️
src/app/data/store.rs 83.87% 30 Missing ⚠️
src/utils/data_units.rs 39.02% 25 Missing ⚠️
.../canvas/components/time_graph/time_chart/points.rs 66.19% 24 Missing ⚠️
src/app.rs 44.11% 19 Missing ⚠️
src/canvas/widgets/mem_graph.rs 83.67% 16 Missing ⚠️
src/canvas/widgets/network_basic.rs 0.00% 12 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   53.95%   54.11%   +0.16%     
==========================================
  Files         109      110       +1     
  Lines       17911    17540     -371     
==========================================
- Hits         9663     9491     -172     
+ Misses       8248     8049     -199

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov