-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: points rework (v1) #1663
Draft
ClementTsang
wants to merge
40
commits into
main
Choose a base branch
from
points_rework_v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
+ Coverage 53.95% 54.11% +0.16%
==========================================
Files 109 110 +1
Lines 17911 17540 -371
==========================================
- Hits 9663 9491 -172
+ Misses 8248 8049 -199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
force-pushed
the
points_rework_v1
branch
2 times, most recently
from
January 20, 2025 22:23
a7f711b
to
250f2b8
Compare
ClementTsang
force-pushed
the
points_rework_v1
branch
from
January 20, 2025 22:24
250f2b8
to
408e81c
Compare
ClementTsang
force-pushed
the
points_rework_v1
branch
2 times, most recently
from
January 25, 2025 06:39
76cab2c
to
7585d39
Compare
ClementTsang
force-pushed
the
points_rework_v1
branch
from
January 25, 2025 06:45
7585d39
to
c3365be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Rework how time series data is stored, and remove the "conversion" intermediary step. More specifically:
DataStore
struct.ConvertedData
intermediary struct (and remove that altogether); we now have more direct access of the raw data.This has the following benefits:
TODO:
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)