Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11278: Survey - converted aria-hidden attributes to inert attributes #1168

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 24, 2025

UHF-11278

What was done

  • On survey javascript converted aria-hidden attributes to inert attributes.
  • Added inert to the skip link as well.

How to install

  • Make sure your instance (front page recommended) is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11278
  • Run make drush-cr

How to test

  • Make sure that you have active survey that pops up when you refresh the page.
  • With VoiceOver try to access the site behind the survey without answering it. This shouldn't be possible.
  • Answer the survey. Now make sure you are able to access the site normally.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1168/html_report/

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1168/html_report/

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1168/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants