Skip to content

Commit

Permalink
Merge pull request #1168 from City-of-Helsinki/UHF-11278
Browse files Browse the repository at this point in the history
UHF-11278: Survey - converted aria-hidden attributes to inert attributes
  • Loading branch information
teroelonen authored Jan 27, 2025
2 parents 1ac79a9 + 4a3fdbd commit 90385a5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
2 changes: 1 addition & 1 deletion dist/js/closable-surveys.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 15 additions & 7 deletions src/js/closable-surveys.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,28 @@ import LocalStorageManager from './localStorageManager';
function toggleOtherContentVisibility() {
const mainContent = document.querySelector('.dialog-off-canvas-main-canvas');
const cookieBanner = document.querySelector('.hds-cc__target');
const skipToMain = document.querySelector('.skip-link--skip-to-main');
const surveyContainer = document.getElementById('helfi-survey__container');

if (mainContent && !mainContent.hasAttribute('aria-hidden') && surveyContainer) {
mainContent.setAttribute('aria-hidden', 'true');
if (mainContent && !mainContent.hasAttribute('inert') && surveyContainer) {
mainContent.setAttribute('inert', '');
} else {
// eslint-disable-next-line no-unused-expressions
mainContent && mainContent.removeAttribute('aria-hidden');
mainContent && mainContent.removeAttribute('inert');
}

if (cookieBanner && !cookieBanner.hasAttribute('aria-hidden') && surveyContainer) {
cookieBanner.setAttribute('aria-hidden', 'true');
if (skipToMain && !skipToMain.hasAttribute('inert') && surveyContainer) {
skipToMain.setAttribute('inert', '');
} else {
// eslint-disable-next-line no-unused-expressions
cookieBanner && cookieBanner.removeAttribute('aria-hidden');
skipToMain && skipToMain.removeAttribute('inert');
}

if (cookieBanner && !cookieBanner.hasAttribute('inert') && surveyContainer) {
cookieBanner.setAttribute('inert', '');
} else {
// eslint-disable-next-line no-unused-expressions
cookieBanner && cookieBanner.removeAttribute('inert');
}
}

Expand Down Expand Up @@ -117,8 +125,8 @@ import LocalStorageManager from './localStorageManager';
survey.remove();
toggleNoScroll(false);
setBodyPaddingRight(false);
focusToCookieBanner();
toggleOtherContentVisibility();
focusToCookieBanner();
}

if (surveyCloseButton) {
Expand Down

0 comments on commit 90385a5

Please sign in to comment.