Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test more services terminate #18807

Merged
merged 8 commits into from
Nov 4, 2024
Merged

test more services terminate #18807

merged 8 commits into from
Nov 4, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 1, 2024 •
edited
Loading

Purpose:

specifically useful for providing coverage for #18775

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • consider port collisions

@altendky altendky requested a review from a team as a code owner November 1, 2024 18:10
@altendky altendky added Added Required label for PR that categorizes merge commit message as "Added" for changelog Tests Changes to tests labels Nov 1, 2024
@altendky altendky mentioned this pull request Nov 1, 2024
Merged
1 task
@altendky altendky requested a review from emlowe November 4, 2024 18:08
@pmaslana pmaslana merged commit bef7a5d into main Nov 4, 2024
362 checks passed
@pmaslana pmaslana deleted the test_more_services_terminate branch November 4, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog Tests Changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @emlowe @pmaslana