Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more start_* service starting consistency #18775

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Oct 26, 2024

Purpose:

way back i had worked to make these files more common towards the end of maybe being able to deduplicate them. this is just a tidy back in that direction. i happened to pick the farmer as 'reference' and then diffed it against each of the others and tweaked until the common parts were coded the same way.

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Oct 26, 2024
@altendky altendky requested a review from AmineKhaldi October 29, 2024 01:24
@altendky altendky marked this pull request as ready for review October 29, 2024 14:04
@altendky altendky requested a review from a team as a code owner October 29, 2024 14:04
@altendky altendky requested review from arvidn and removed request for arvidn October 29, 2024 20:07
@altendky altendky marked this pull request as draft November 1, 2024 18:13
@altendky altendky mentioned this pull request Nov 1, 2024
1 task
@altendky altendky closed this Nov 4, 2024
@altendky altendky reopened this Nov 4, 2024
@altendky altendky marked this pull request as ready for review November 4, 2024 20:35
@altendky altendky requested a review from emlowe November 4, 2024 20:37
Copy link

Pull Request Test Coverage Report for Build 11672066746

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 7 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.93%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/server/start_data_layer.py 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/daemon/client.py 1 74.1%
chia/rpc/rpc_server.py 1 87.67%
chia/server/node_discovery.py 2 80.92%
chia/full_node/full_node.py 6 85.86%
Totals Coverage Status
Change from base Build 11671381623: 0.03%
Covered Lines: 102819
Relevant Lines: 112843

💛 - Coveralls

@pmaslana pmaslana merged commit 3f6977f into main Nov 5, 2024
361 checks passed
@pmaslana pmaslana deleted the more_start_service_consistency branch November 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants