Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate tasks from retrievable deals #209

Merged
merged 3 commits into from
Feb 19, 2024
Merged

feat: generate tasks from retrievable deals #209

merged 3 commits into from
Feb 19, 2024

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 8, 2024

Quoting from the design doc:

Rework the code defining retrieval tasks for a new Meridian round to pick CIDs from the list of FIL+ LDN deals. Set columns provider_address and protocol to NULL.

In the future, we will need metadata to match IPNI responses to this particular deal. We don’t have that yet, so let's keep the schema simple and the table small in size for now.

Verify that the response of GET /rounds/meridian/{contract}/{round-index} converts NULL values in provider_address and protocol to undefined values in JavaScript, therefore excluding these fields from the JSON response.

The goal here is to preserve the provider address & protocol in the responses for older rounds where the retrieval tasks were defined with the provider address and protocol to use.

Links:

@bajtos bajtos requested a review from juliangruber February 8, 2024 17:32
@bajtos
Copy link
Member Author

bajtos commented Feb 8, 2024

This is a breaking change for Spark checker nodes. Nodes running the Spark version older than 1.8.0 will stop earning rewards.

I guess we should wait with this change until we modify spark-api to start rejecting outdated clients on Feb 15th.

@juliangruber
Copy link
Member

This is a breaking change for Spark checker nodes. Nodes running the Spark version older than 1.8.0 will stop earning rewards.

I guess we should wait with this change until we modify spark-api to start rejecting outdated clients on Feb 15th.

Yeah now that we have communicated this I think we have to

lib/round-tracker.js Show resolved Hide resolved
@bajtos

This comment was marked as resolved.

@bajtos bajtos enabled auto-merge (squash) February 19, 2024 10:37
@bajtos bajtos merged commit bd4586c into main Feb 19, 2024
6 checks passed
@bajtos bajtos deleted the tasks-from-deals branch February 19, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants