Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow measurements with no provider #221

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 19, 2024

We don't have the providerAddress & protocol fields for deals that are not advertised to IPNI.

This PR fixes a regression introduced by #209.

Links:

We don't have the providerAddress & protocol fields for deals
that are not advertised to IPNI.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos merged commit 6fbf87f into main Feb 19, 2024
8 checks passed
@bajtos bajtos deleted the measurements-without-provider branch February 19, 2024 12:30
@bajtos
Copy link
Member Author

bajtos commented Feb 19, 2024

/
@juliangruber hindsight please 🙏🏻

Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants