Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when sinAngle is < 1. the value of expandWidth was too much: #12434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix bug when sinAngle is < 1. the value of expandWidth was too much: #12434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c42b5
fix bug when sinAngle is < 1. the value of expandWidth was too much:
mickae1 Jan 14, 2025
19f9a08
Merge branch 'main' into polyline
ggetz Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/engine/Source/Shaders/PolylineCommon.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ vec4 getPolylineWindowCoordinatesEC(vec4 positionEC, vec4 prevEC, vec4 nextEC, f
vec2 u = -thisSegmentForwardWC;
vec2 v = leftWC;
float sinAngle = abs(u.x * v.y - u.y * v.x);
expandWidth = clamp(expandWidth / sinAngle, 0.0, width * 2.0);
expandWidth = clamp(expandWidth / sinAngle, 0.0, width * 0.5);
}

vec2 offset = leftWC * expandDirection * expandWidth * czm_pixelRatio;
Expand Down
Loading