fix bug when sinAngle is < 1. the value of expandWidth was too much: #12434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit it to the default: expandWidth = width * 0.5;
|
Thank you for the pull request, @mickae1! ✅ We can confirm we have a CLA on file for you. |
|
Thanks for the fix @mickae1! This fix looks reasonable to me. I'll test this out shortly to confirm. |
a quick sandcastle to test it : |
|
Thanks @mickae1! I was able to verify this is working in your example, as well as with existing polyline dash materials and the meridian edge case. Please add a summary to |
|
In the CHANGES.md, can I just put :
fix bug when sinAngle is < 1. the value of expandWidth was too much
…On Tue, Jan 21, 2025 at 8:44 PM Gabby Getz ***@***.***> wrote:
Thanks @mickae1 <https://github.com/mickae1>! I was able to verify this
is working in your example, as well as with existing polyline dash
materials and the meridian edge case.
Please add a summary to CHANGES.md and yourself to CONTRIBUTORS.md if you
haven't done so already. Then this should be all good to merge!
—
Reply to this email directly, view it on GitHub
<#12434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAHMCFWWSCC4GX6MRW7ZN32L2PTBAVCNFSM6AAAAABVFOXRNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGU4TKNJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mickae1 Sure. You can link to the fixed issue as well. Thanks@ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug when sinAngle is < 1. the value of expandWidth was too much:
limit it to the default: expandWidth = width * 0.5;
fix issue: #12427
and maybe this one : #7645