Feature/upgrade django #127
Conversation
Now part of Django
And to djangorestframework 3.11.2 and django-filter 2.2.0
For correct redirection if user is not logged in
There was a problem hiding this comment.
I was still running PostgreSQL 9.6 on my work machine, so I had to upgrade that first, but then the unittests passed. That's a good sign!
I also tried python manage.py runserver. That seems to run without issues, however there appears to be a subtle breaking change in the implementation of the {{ prefetched_* | escapejs }} variable interpolations in vre/templates/vre/base.html on lines 62 and 63. It now outputs a string that starts with the character b, which JSON.parse (rightly) rejects. Would be great if you could fix that, and then double-check again that the VRE runs in the browser without any errors in the console.
You seem to have an aggressive autoformatter, which (in my humble opinion) makes some odd choices when it comes to wrapping long lines. I guess that is a matter of taste; I will appreciate it if you align it closer to the idea behind 1TBS, but I will not insist. However, if possible, please tell it to only reformat lines that you changed.
Other than that, I'm happy with what I'm reading!
os import was removed for upgrade to Django 4.1 which uses pathlib but we need it again because one of the hotfixes uses it
Upgrade to Django 4.1 and djangorestframework 3.14 (the latest versions). I did not stop at Django 3.2 (LTS) because the next version (4.2) will be an LTS and will still support Python 3.8. I cleaned up the code here and there in files that I was changing. Closes #119.