-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh phase 2 #133
Refresh phase 2 #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! I have a few minor comments.
Processing a review comment bij @tijmenbaarda in #133.
Processing a review comment by @tijmenbaarda in #133.
Thanks to both for your reviews! I have processed Tijmen's comments. This branch should be rebased on |
This is needed because of a subtle breaking change in Bootstrap 3.4.
Processing a review comment bij @tijmenbaarda in #133.
Processing a review comment by @tijmenbaarda in #133.
f2d6a21
to
cbbb2ae
Compare
Where #126 prepared the backend for #118, the current PR is doing the same for the frontend, including changes related to #125, #119, #117, #120, #121, #122, #130 and #131. I will push the actual separation, along with some final cleanup, in the third and last installment of this series.
I did the following things on this branch:
package.json
, upgrading most of them along the way, and started tracking thepackage-lock.json
. The only remaining seriously outdated package is Bootstrap; updating that package can wait until later.index.html
by the backend (they were sourced fromvre/templates/vre/client_templates.html
, which has now been deleted).Along the way, I also made some transitional changes that are no longer visible in the end result. I wanted to have the test suite running as soon as possible, so that I could verify that my infrastructure changes didn't break anything. This meant that I had to cater changes specifically to Browserify and Handlebars along the way, which later became obsolete.
By way of review, I suggest that @tijmenbaarda and @lukavdplas both do the following:
package.json
.rollup.config.js
and thekarma.conf.js
for any surprises.README.md
and check whether they seem clear, complete and consistent with the above.vre/static/vre/**/*.mustache
) just to get a quick impression of what these templates look like.vre/static/vre/**/*.view.js
) just to see the notation by which the template is imported.vre/static/vre/**/*.test.js
). Give it a hard stare and check for any surprises.