Seo #942
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| #Generated by Gradle | ||
| saos.version=0.9.6-SNAPSHOT |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| <url> | ||
| <loc>https://www.saos.org.pl/</loc> | ||
| <lastmod>2015-09-30</lastmod> | ||
|
There was a problem hiding this comment. the loc should be configured, you'll have the same value for test and devel env There was a problem hiding this comment. We have to talk about it a bit. |
||
| <changefreq>weekly</changefreq> | ||
| </url> | ||
| <url> | ||
| <loc>https://www.saos.org.pl/search</loc> | ||
| <lastmod>2015-09-30</lastmod> | ||
| <changefreq>daily</changefreq> | ||
| </url> | ||
| <url> | ||
| <loc>https://www.saos.org.pl/analysis</loc> | ||
| <lastmod>2015-09-30</lastmod> | ||
| <changefreq>weekly</changefreq> | ||
| </url> | ||
| <url> | ||
| <loc>https://www.saos.org.pl/help</loc> | ||
| <lastmod>2015-09-30</lastmod> | ||
| <changefreq>daily</changefreq> | ||
| </url> | ||
| </urlset> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%> | ||
| <%@ include file="/WEB-INF/view/common/taglibs.jsp" %> | ||
|
|
||
|
|
||
| <meta name="keywords" content="<spring:message code='analysis.meta.keywords' />" /> | ||
| <meta name="description" content="<spring:message code='analysis.meta.pageDescription'/>"/> | ||
|
|
||
|
|
||
| <%-- Open graph ogp.me --%> | ||
| <%@ include file="../common/openGraphMeta.jsp" %> | ||
| <meta property="og:title" content="<spring:message code="pageTitle.analysis" /> - <spring:message code="saos.fullname"/>"> | ||
| <meta property="og:description" content="<spring:message code='analysis.meta.pageDescription'/>"> | ||
|
|
||
|
|
||
| <title><spring:message code="pageTitle.analysis" /> - <spring:message code="saos.fullname"/></title> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%> | ||
| <%@ include file="/WEB-INF/view/common/taglibs.jsp" %> | ||
|
|
||
|
|
||
| <%-- Open graph ogp.me --%> | ||
| <spring:eval var="domainName" expression="@exposedProperties.getProperty('domain.name')"/> | ||
|
|
||
| <meta property="og:site_name" content="Saos"> | ||
| <meta property="og:type" content="object"> | ||
|
There was a problem hiding this comment. Should the og:type be 'website'? |
||
| <meta property="og:image" content="${domainName}/static/image/saosLogo.png"> | ||
| <meta property="og:url" content="${domainName}${requestScope['javax.servlet.forward.servlet_path']}"> | ||
|
|
||
|
|
||
|
There was a problem hiding this comment. You shouldn't take the request url like this. I told you earlier that you should use it HttpServletRequestUtils service to get the request url - we are behind proxy on prod and you have to take it into account. And you don't care about query parameters here, I'm not sure if it's ok. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <%@ page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%> | ||
| <%@ include file="/WEB-INF/view/common/taglibs.jsp" %> | ||
|
|
||
|
|
||
| <h1> | ||
|
There was a problem hiding this comment. I don't think the h1 should be around logo. It's not the case for which h1 has been designed for, don't you think? |
||
| <a href="${contextPath}/" class="saos-logo-link" title="<spring:message code='linkToMainPage'/>" aria-label="<spring:message code='linkToMainPage'/>" > | ||
| <img class="saos-logo" src="${contextPath}/static/image/saosLogoNoText.png" alt="<spring:message code="saos.fullname"/> - <spring:message code='saos.logo.alt' />" /> | ||
| </a> | ||
|
|
||
| <a href="${contextPath}/" class="saos-logo-mobile-link" title="<spring:message code='linkToMainPage'/>" aria-label="<spring:message code='linkToMainPage'/>"> | ||
| <img class="saos-logo-mobile" src="${contextPath}/static/image/saosLogoMobile.png" alt="<spring:message code="saos.fullname"/> - <spring:message code='saos.logo.alt' />" /> | ||
| </a> | ||
| </h1> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to name these: releasedBy.neuter, releasedBy.feminine, releasedBy.masculine. Different judgment types can share these keys.