Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seo #942

Closed
wants to merge 10 commits into from
Closed

Seo #942

wants to merge 10 commits into from

Conversation

pawelczak
Copy link
Contributor


# domain name
domain.name = https://saos.org.pl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have here https://www.saos.org.pl
It would be better to propagate this address because it doesn't need a redirect when invoked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, the domain name should be taken from request rather than to be const string (the same for every saos instance), see the usage of HttpServletRequestUtils.

@lukdumi lukdumi assigned pawelczak and unassigned lukdumi Oct 5, 2015
@lukdumi
Copy link
Contributor

lukdumi commented Oct 5, 2015

SAOS - takie wyrażenie musimy dodać, żeby było częściej na stronie głównej i może wyszukiwarce. Np. w tytule, altcie loga. Teraz google po wpisaniu saos nie pokazuje naszego serwisu na pierwszej stronie, co jest dziwne.

<meta property="og:site_name" content="Saos">
<meta property="og:type" content="object">
<meta property="og:image" content="${domainName}/static/image/saosLogo.png">
<meta property="og:url" content="${domainName}${requestScope['javax.servlet.forward.servlet_path']}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check globalVariables.jsp

Łukasz Pawełczak added 2 commits October 6, 2015 10:25
@pawelczak pawelczak assigned lukdumi and unassigned pawelczak Oct 6, 2015
details.meta.releasedBy.feminine = wydana przez
details.meta.releasedBy.masculine = wydany przez
details.meta.withSignature = o sygnaturze
details.meta.containing = w składzie sędziowskim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a strange name of the key, I suggest details.meta.judges

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

</c:when>
<c:otherwise>
<c:if test="${!empty metaCourtType}" >
<c:set var="detailsMetaDescription" value="${detailsMetaDescription} ${releasedBy} ${metaCourtType}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postanowienie o sygnaturze KIO 225/13 wydane przez Krajowa Izba Odwoławcza w składzie sędziowskim Katarzyna Prowadzisz.
should be
Postanowienie o sygnaturze KIO 225/13 wydane przez Krajową Izbę Odwoławczą w składzie sędziowskim: Katarzyna Prowadzisz.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lukdumi lukdumi assigned pawelczak and unassigned lukdumi Oct 7, 2015
Łukasz Pawełczak added 2 commits October 8, 2015 09:36
@pawelczak pawelczak assigned lukdumi and unassigned pawelczak Oct 8, 2015
@lukdumi
Copy link
Contributor

lukdumi commented Oct 8, 2015

Some remarks:

  1. A description of KIO judgment with more than 1 signature looks strange, there is a new line character inside, e.g.:
 Wyrok o sygnaturze KIO 1629/11, 

KIO 1643/11 wydany przez Krajową Izbę Odwoławczą w składzie sędziowskim: Anna Packo, Katarzyna Prowadzisz, Marzena Teresa Ordysińska.
  1. A description of SN judgment - the chambers are badly conjugated, e.g.
    Postanowienie SN o sygnaturze II PK 144/09 wydane przez Izba Pracy, Ubezpieczeń Społecznych i Spraw Publicznych w składzie sędziowskim: Zbigniew Hajn.

Maybe we should put the 'Izba...' into apostrophes? e.g.
Postanowienie SN o sygnaturze II PK 144/09 wydane przez "Izba Pracy, Ubezpieczeń Społecznych i Spraw Publicznych" w składzie sędziowskim: Zbigniew Hajn.

<c:if test="${!empty metaPageDescriptionCode}">
<meta name="description" content="<spring:message code='${metaPageDescriptionCode}'/>"/>
</c:if>
</c:if>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code above is important. The meta description cannot be the same for different pages. Now we have the same description for /search and /search?judgeName="Sylwester+Kuchnio". Google won't allow this because it would look strange to have many result links with the same description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about creating description for search (in the future), that contains serach parameters, so it would make it not the same for different pages.
For now I'll leave old version with pageDescription.
👌

@lukdumi lukdumi assigned pawelczak and unassigned lukdumi Oct 8, 2015
@pawelczak
Copy link
Contributor Author

Ad. 2) Desciption:
Postanowienie SN o sygnaturze II PK 144/09 wydane przez Izba Pracy, Ubezpieczeń Społecznych i Spraw Publicznych w składzie sędziowskim: Zbigniew Hajn.
also hurt my eyes, but I didn't have idea what to do with it. Your suggestion is good.

@pawelczak pawelczak assigned lukdumi and unassigned pawelczak Oct 9, 2015
@lukdumi
Copy link
Contributor

lukdumi commented Oct 12, 2015

Łukasz, it seems to be almost ok now. I only wonder if it's ok to have the same keywords and og:descriptions for different pages.

@lukdumi lukdumi assigned pkwiatek and pawelczak and unassigned lukdumi and pkwiatek Oct 12, 2015
@pawelczak
Copy link
Contributor Author

  1. google webmaster tools doesn't report same keywords as an error (it does report same description as an error). So I guess it's not a technical problem.
    From the other standpoint, having same keywords for different pages makes pages compete with each other for the same query. It's called "keyword cannibalisation". Same keywords are displayed only in "search" view, so I don't know if we should worry about it. Allegro doesn't show keywords in search view and Amazon does..
  2. og:description unlike a regular meta description tag, it won’t affect your SEO. - https://blog.kissmetrics.com/open-graph-meta-tags/ good read

The more I read about optimization meta tags for search engines the more I find articles, that says "Metatags are becoming less and less important for search engines".

@pawelczak
Copy link
Contributor Author

I thought more about it and I think we should have unique keywords and description for search pages.

@pawelczak pawelczak assigned lukdumi and unassigned pawelczak Oct 12, 2015
@lukdumi lukdumi closed this Oct 12, 2015
@pawelczak pawelczak deleted the pawelczak_seo branch October 12, 2015 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants