-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seo #942
Seo #942
Conversation
|
||
# domain name | ||
domain.name = https://saos.org.pl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have here https://www.saos.org.pl
It would be better to propagate this address because it doesn't need a redirect when invoked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, the domain name should be taken from request rather than to be const string (the same for every saos instance), see the usage of HttpServletRequestUtils.
SAOS - takie wyrażenie musimy dodać, żeby było częściej na stronie głównej i może wyszukiwarce. Np. w tytule, altcie loga. Teraz google po wpisaniu saos nie pokazuje naszego serwisu na pierwszej stronie, co jest dziwne. |
<meta property="og:site_name" content="Saos"> | ||
<meta property="og:type" content="object"> | ||
<meta property="og:image" content="${domainName}/static/image/saosLogo.png"> | ||
<meta property="og:url" content="${domainName}${requestScope['javax.servlet.forward.servlet_path']}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check globalVariables.jsp
details.meta.releasedBy.feminine = wydana przez | ||
details.meta.releasedBy.masculine = wydany przez | ||
details.meta.withSignature = o sygnaturze | ||
details.meta.containing = w składzie sędziowskim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a strange name of the key, I suggest details.meta.judges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
</c:when> | ||
<c:otherwise> | ||
<c:if test="${!empty metaCourtType}" > | ||
<c:set var="detailsMetaDescription" value="${detailsMetaDescription} ${releasedBy} ${metaCourtType}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postanowienie o sygnaturze KIO 225/13 wydane przez Krajowa Izba Odwoławcza w składzie sędziowskim Katarzyna Prowadzisz.
should be
Postanowienie o sygnaturze KIO 225/13 wydane przez Krajową Izbę Odwoławczą w składzie sędziowskim: Katarzyna Prowadzisz.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Some remarks:
Maybe we should put the 'Izba...' into apostrophes? e.g. |
<c:if test="${!empty metaPageDescriptionCode}"> | ||
<meta name="description" content="<spring:message code='${metaPageDescriptionCode}'/>"/> | ||
</c:if> | ||
</c:if> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code above is important. The meta description cannot be the same for different pages. Now we have the same description for /search and /search?judgeName="Sylwester+Kuchnio". Google won't allow this because it would look strange to have many result links with the same description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about creating description for search (in the future), that contains serach parameters, so it would make it not the same for different pages.
For now I'll leave old version with pageDescription.
👌
Ad. 2) Desciption: |
Łukasz, it seems to be almost ok now. I only wonder if it's ok to have the same keywords and og:descriptions for different pages. |
The more I read about optimization meta tags for search engines the more I find articles, that says "Metatags are becoming less and less important for search engines". |
I thought more about it and I think we should have unique keywords and description for search pages. |
#941