Code

fix(let): refactor let#526

Code

Merged

mhagmajer merged 17 commits intoCatchTheTornado:masterCatchTheTornado/askql:masterfrom dastin-sandura:issue_521_refactor_letdastin-sandura/askql:issue_521_refactor_letCopy head branch name to clipboardOct 30, 2020

+184-37

Commits

Commits on Oct 25, 2020

• Default issue template, proposed by Github

  dastin-sandura

  authored
  a938eed

  Copy full SHA for a938eed

• Merge pull request #1 from dastin-sandura/feature-request-issue-template

  Show description for ce1de3c
  dastin-sandura

  authored
  ce1de3c

  Copy full SHA for ce1de3c

• Update feature request issue template

  Show description for 3856a6e
  dastin-sandura

  authored
  3856a6e

  Copy full SHA for 3856a6e

• Merge pull request #3 from dastin-sandura/feature-request-issute-template

  Show description for 2b2c992
  dastin-sandura

  authored
  2b2c992

  Copy full SHA for 2b2c992

Commits on Oct 28, 2020

• Merge pull request #4 from xFAANG/master

  Show description for 58a8383
  dastin-sandura

  authored
  58a8383

  Copy full SHA for 58a8383

• Changes

  Show description for 7dd2b2b
  dastin-sandura

  committed
  7dd2b2b

  Copy full SHA for 7dd2b2b

• remove logs, unused function, and check if code === const

  dastin-sandura

  committed
  b0220a7

  Copy full SHA for b0220a7

• change 'let' test retrieval of a let variable value instead of checking what let returns

  dastin-sandura

  committed
  8905c13

  Copy full SHA for 8905c13

• remove code which runs when using 'assign' from let.ts

  dastin-sandura

  committed
  a3c350c

  Copy full SHA for a3c350c

Commits on Oct 29, 2020

• remove condition on assign, add flag to decide when to throw 'unknown variable error'

  dastin-sandura

  committed
  299c9a8

  Copy full SHA for 299c9a8

• remove commented code from assign.ts

  dastin-sandura

  committed
  7a7b517

  Copy full SHA for 7a7b517

• Test for 'assign' which makes sure that you cannot assign value to a constant after it was initialized

  dastin-sandura

  committed
  1112880

  Copy full SHA for 1112880

• Change test naming

  dastin-sandura

  committed
  8fe68fd

  Copy full SHA for 8fe68fd

• const.test for making sure that const is Object.isFrozen()

  dastin-sandura

  committed
  4b63579

  Copy full SHA for 4b63579

• assign test for throwing when assigning value to an undeclared variable

  dastin-sandura

  committed
  2962a05

  Copy full SHA for 2962a05

• assign test for checking assignment to reserved keyword variables

  dastin-sandura

  committed
  f3b4822

  Copy full SHA for f3b4822

Commits on Oct 30, 2020

• change if to proper jest expect assertion

  dastin-sandura

  committed
  6bd4b58

  Copy full SHA for 6bd4b58