fix(let): refactor let #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default issue template, proposed by Github
add questions about the details and importance of this feature request
…late Update feature request issue template
|
Hi @YonatanKra , could you please review my changes in this PR? 🙂 |
feat(chore): feature request issue template (CatchTheTornado#525)
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
reviewed
Oct 28, 2020
mhagmajer
suggested changes
Oct 28, 2020
There was a problem hiding this comment.
Good progress @dastin-sandura, thanks for working on this 👍
dastin-sandura
force-pushed
the
issue_521_refactor_let
branch
from
cb6accc to
7dd2b2b
Compare
|
Thank you for your review 😄 I will review your comments and make changes |
…ng what let returns
YonatanKra
requested changes
Oct 29, 2020
…constant after it was initialized
|
Thank you for your reviews 😄 @mhagmajer and @YonatanKra |
YonatanKra
requested changes
Oct 29, 2020
mhagmajer
approved these changes
Oct 30, 2020
km4
pushed a commit
to km4/askql
that referenced
this pull request
Nov 28, 2020
* Default issue template, proposed by Github * Update feature request issue template add questions about the details and importance of this feature request * Changes add file with implementation of const, remove const parts from let.ts extract const and assign from let.ts, extract tests for const and assign from let tests * remove logs, unused function, and check if code === const * change 'let' test retrieval of a let variable value instead of checking what let returns * remove code which runs when using 'assign' from let.ts * remove condition on assign, add flag to decide when to throw 'unknown variable error' * remove commented code from assign.ts * Test for 'assign' which makes sure that you cannot assign value to a constant after it was initialized * Change test naming * const.test for making sure that const is Object.isFrozen() * assign test for throwing when assigning value to an undeclared variable * assign test for checking assignment to reserved keyword variables * change if to proper jest expect assertion
km4
added a commit
to km4/askql
that referenced
this pull request
Nov 28, 2020
This reverts commit 43385c3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #521