feat: Cancel mode NoFall #5534
Merged
feat: Cancel mode NoFall #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/player/nofall/modes/NoFallCancel.kt
Fixed
Show fixed
Hide fixed
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/player/nofall/modes/NoFallCancel.kt
Fixed
Show fixed
Hide fixed
1zun4
reviewed
Feb 5, 2025
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/player/nofall/modes/NoFallCancel.kt
Outdated
Show resolved
Hide resolved
1zun4
reviewed
Feb 5, 2025
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/player/nofall/modes/NoFallCancel.kt
Outdated
Show resolved
Hide resolved
1zun4
approved these changes
Feb 7, 2025
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/player/nofall/modes/NoFallCancel.kt
Show resolved
Hide resolved
|
It's been a few hours already. I have broken the pull request. |
LMFAO, we might need to rebase the commit away to fix this... GitHub 👍! (not sure if this would happen on Codeberg but it's pretty funny) |
|
@1zun4 I'm going to rebase the commit away so hopefully it works lol |
|
rebased |
|
merging is blocked 💀 |
|
got rid of merge commits and it still complains |
|
it only shows in the preview merge experience thing, probably doesn't matter |
|
Now my commit is gone. Thanks. I will try to push it again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedrun any% getting PR closed: This also exists in LiquidBounce Legacy
Works on Miniblox (you need to use the translation layer (discontinued, rip)) with fall distance mode Constant & set to 3, also disable reset fall distance since it doesn't work on Miniblox for some reason 💀
VulcanTP288 also works on Miniblox but this also works
Probably works on some other servers.