Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opt-out dialog is vertically cut off if height is set to auto #506

Merged
merged 8 commits into from
Jan 23, 2025
+8 −2
Merged

fix: Opt-out dialog is vertically cut off if height is set to auto #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
32a1e75
100% height when opened
ataromoku Jan 22, 2025
c9e9a81
Merge branch 'main' into phoenix/flyout-hotfix
ataromoku Jan 22, 2025
2011ab3
Updating vdiff goldens
github-actions[bot] Jan 22, 2025
aaadb6c
Merge pull request #507 from BrightspaceUI/ghworkflow/vdiff-pr-506
ataromoku Jan 22, 2025
43677bc
add fade behind flyout
ataromoku Jan 22, 2025
e8a6af2
fix lint
ataromoku Jan 22, 2025
0caaa97
fix style
ataromoku Jan 22, 2025
3c5c53a
Merge branch 'main' into phoenix/flyout-hotfix
ataromoku Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/opt-in-flyout/flyout-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,19 @@ class FlyoutImplementation extends composeMixins(
heading1Styles,
css`
:host {
height: var(--d2l-flyout-custom-element-height, 100%);
height: var(--d2l-flyout-custom-element-height, auto);
overflow: hidden;
pointer-events: none;
position: absolute;
width: 100%;
}

:host([opened]) {
background-color: rgba(255, 255, 255, 0.7);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what the semi-transparency is being used for here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what this is being used for now. Follow-up question, do you know why this is using white as opposed to regolith like d2l-backdrop. I see the transparency is at least consistent.

height: 100%;
pointer-events: auto;
}

#flyout {
background-color: white;
border-bottom: 1px solid var(--d2l-color-mica);
Expand All @@ -62,7 +68,7 @@ class FlyoutImplementation extends composeMixins(
overflow: visible;
padding-bottom: 2rem;
pointer-events: auto;
position: var(--d2l-flyout-custom-element-position, absolute);
position: var(--d2l-flyout-custom-element-position, relative);
top: var(--d2l-flyout-custom-element-top, 0);
width: 100%;
z-index: var(--d2l-flyout-custom-element-z-index, 900);
Expand Down
Binary file modified test/components/opt-in-flyout/golden/flyout-impl/chromium/closed-focus.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/components/opt-in-flyout/golden/flyout-impl/chromium/closed.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading