fix: Opt-out dialog is vertically cut off if height is set to auto #506
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GZolla
approved these changes
Jan 23, 2025
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dbatiste
reviewed
Jan 23, 2025
| overflow: hidden; | ||
| pointer-events: none; | ||
| position: absolute; | ||
| width: 100%; | ||
| } | ||
|
|
||
| :host([opened]) { | ||
| background-color: rgba(255, 255, 255, 0.7); |
There was a problem hiding this comment.
Curious what the semi-transparency is being used for here.
There was a problem hiding this comment.
I see what this is being used for now. Follow-up question, do you know why this is using white as opposed to regolith like d2l-backdrop. I see the transparency is at least consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://desire2learn.atlassian.net/browse/PHNX-2526
Problem
Previous PR1 PR2 addressed an issue where the entire page shifted upward when
scrollIntoViewwas called. This happened because theopt-in-flayoutcomponent overflowed out of view. However, that fix introduced a new problem, the dialog window is now getting cut off because the component's height is too small to fit it in.Solution
Set the height to
autoby default and use100%to fill the entire space only when theopt-in-flyoutis in open state. Hide the content behind theopt-in-flyoutusing a fade.Demo
Normal style
flyout-normal-with-fade.mp4
Position fixed style
flyout-fixed-with-fade.mp4
Before
flyout-before.mp4