Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make Go Pipeline better and safer #89

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: Make Go Pipeline better and safer #89

merged 1 commit into from
Nov 15, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 14, 2023 •
edited
Loading

Please see comments below.

@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Nov 14, 2023
jd4235
jd4235 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@jd4235 jd4235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kehoecj
kehoecj approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These LGTM - thanks for the PR @szepeviktor !

@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor
Copy link
Contributor Author

@kehoecj Please give me more work. It helps to chase away depression.

jackswiney
jackswiney approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jackswiney jackswiney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kehoecj kehoecj merged commit 088be61 into Boeing:main Nov 15, 2023
4 checks passed
@szepeviktor szepeviktor deleted the patch-1 branch November 15, 2023 16:58
@kehoecj
Copy link
Collaborator

kehoecj commented Nov 15, 2023 •
edited
Loading

@kehoecj Please give me more work. It helps to chase away depression.

@szepeviktor We'd love to have you contribute to any of our open issues. You can choose from any but here's a few that could be good to get started with:

@szepeviktor
Copy link
Contributor Author

Unfortunately, my expertise is limited to the underlying technologies: everything that makes config-file-validator run.

shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
@szepeviktor @shiina4119
Make Go Pipeline better and safer (Boeing#89)
ecc4a49
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
@szepeviktor @shiina4119
Make Go Pipeline better and safer (Boeing#89)
ba4b88a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackswiney jackswiney jackswiney approved these changes

@kehoecj kehoecj kehoecj approved these changes

@jd4235 jd4235 jd4235 approved these changes

Assignees
No one assigned
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szepeviktor @kehoecj @jd4235 @jackswiney