Client Assertion implementation now accepts an async callback as well as a string argument #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bgavrilMS
reviewed
Apr 9, 2024
bgavrilMS
reviewed
Apr 9, 2024
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo,
Avery-Dunn,
jo-arroyo and
konstantin-msft
as code owners
bgavrilMS
reviewed
Apr 10, 2024
lib/msal-node/docs/initialize-confidential-client-application.md
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
samples
bgavrilMS
reviewed
Apr 24, 2024
bgavrilMS
reviewed
Apr 24, 2024
bgavrilMS
reviewed
Apr 24, 2024
lib/msal-node/test/client/ConfidentialClientApplication.spec.ts
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 24, 2024
bgavrilMS
reviewed
Apr 24, 2024
bgavrilMS
reviewed
Apr 24, 2024
lib/msal-node/docs/initialize-confidential-client-application.md
Outdated
Show resolved
Hide resolved
I'll be updating the unit tests shortly. I wanted to see if you approved of the proof-of-concept in this PR. |
bgavrilMS
reviewed
Apr 25, 2024
bgavrilMS
approved these changes
Apr 25, 2024
neha-bhargava
approved these changes
Apr 29, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client assertion can currently be provided by a developer as a string. This PR allows a developer to provide an async callback (which will resolve to a string) as the client assertion.
The client assertion initialization has been removed from ConfidentialClient's constructor and is now initialized inside of buildOauthClientConfiguration, called during every acquireToken call.
Note: Applied Boy-Scout-Rule on UsernamePasswordClient.spec.ts. Only the last test in the file is relevant for this review. Now this test file is up-to-date and mirrors ClientCredentialsClient.spec.ts and OnBehalfOfClient.spec.ts.