Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msal-node] Confidential Client - Client Assertion implementation should accept callback instead of string argument #7013

Closed
KarishmaGhiya opened this issue Apr 8, 2024 · 3 comments · Fixed by #7014
Assignees
Labels
confidential-client Issues regarding ConfidentialClientApplications feature Feature requests. msal-node Related to msal-node package

Comments

@KarishmaGhiya
Copy link
Contributor

Core Library

MSAL Node (@azure/msal-node)

Wrapper Library

Not Applicable

Public or Confidential Client?

Confidential

Description

The client assertion implementation for confidential client should take a user callback that returns a string instead of accepting a string assertion. This will extend the usability of the API to allow users for refreshing the assertion token etc. .NET and Java implementation of MSAL already support this.

Source

Internal (Microsoft)

@KarishmaGhiya KarishmaGhiya added feature-unconfirmed question Customer is asking for a clarification, use case or information. labels Apr 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Apr 8, 2024
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package labels Apr 8, 2024
@KarishmaGhiya
Copy link
Contributor Author

cc: @Robbie-Microsoft @bgavrilMS

@bgavrilMS bgavrilMS added feature Feature requests. and removed question Customer is asking for a clarification, use case or information. Needs: Attention 👋 Awaiting response from the MSAL.js team feature-unconfirmed labels Apr 9, 2024
@bgavrilMS
Copy link
Member

Thanks, @KarishmaGhiya .

@Robbie-Microsoft - can you please propose an API here similar to what .NET has, something like WithClientAssertion(await GetAssertion()). The key point is that it needs to be async.

@Robbie-Microsoft
Copy link
Collaborator

Robbie-Microsoft commented Apr 9, 2024

@bgavrilMS sure. Before you left that comment, I made my own implementation. See my draft PR here. I didn't take async into account though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confidential-client Issues regarding ConfidentialClientApplications feature Feature requests. msal-node Related to msal-node package
Projects
None yet
3 participants