Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging to make regional scenarios more clear #6641

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Oct 31, 2023

Was able to confirm the regional configuration api works. Logs make the used endpoint misleading.
Fix for #6510

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #6641 (7ab89e4) into dev (81d34b4) will decrease coverage by 5.60%.
Report is 385 commits behind head on dev.
The diff coverage is 63.85%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.72% <ø> (+0.21%) ⬆️ Carriedforward from 34670e3
msal-browser 78.73% <ø> (-7.74%) ⬇️ Carriedforward from 34670e3
msal-common ?
msal-core ?
msal-node 80.68% <ø> (-2.71%) ⬇️
msal-node-extensions 68.36% <63.58%> (-7.28%) ⬇️ Carriedforward from 34670e3
msal-react 94.21% <ø> (-0.48%) ⬇️ Carriedforward from 34670e3
node-token-validation ?

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <ø> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
... and 72 more

... and 175 files with indirect coverage changes

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@github-actions github-actions bot removed the msal-common Related to msal-common package label Nov 3, 2023
@trwalke trwalke enabled auto-merge (squash) November 8, 2023 06:19
@trwalke trwalke merged commit a274857 into dev Nov 8, 2023
35 of 38 checks passed
@trwalke trwalke deleted the trwalke/RegionalHostLogs branch November 8, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants