Adding logging to make regional scenarios more clear (#6641)

Was able to confirm the regional configuration api works. Logs make the used endpoint misleading. Fix for #6510 --------- Co-authored-by: trwalke <[email protected]>
AzureAD · Nov 8, 2023 · a274857 · a274857
1 parent d375742
commit a274857
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/change/@azure-msal-node-92a2e589-8556-4d4c-8d36-f7375d161618.json b/change/@azure-msal-node-92a2e589-8556-4d4c-8d36-f7375d161618.json
@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Adding logging to make regional scenarios more clear",
+  "packageName": "@azure/msal-node",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/lib/msal-node/src/client/ClientApplication.ts b/lib/msal-node/src/client/ClientApplication.ts
@@ -412,17 +412,18 @@ export abstract class ClientApplication {
             : this.config.auth.azureCloudOptions;
 
         // using null assertion operator as we ensure that all config values have default values in buildConfiguration()
-        this.logger.verbose(
-            `building oauth client configuration with the authority: ${authority}`,
-            requestCorrelationId
-        );
         const discoveredAuthority = await this.createAuthority(
             authority,
             azureRegionConfiguration,
             requestCorrelationId,
             userAzureCloudOptions
         );
 
+        this.logger.info(
+            `Building oauth client configuration with the following authority: ${discoveredAuthority.tokenEndpoint}.`,
+            requestCorrelationId
+        );
+
         serverTelemetryManager?.updateRegionDiscoveryMetadata(
             discoveredAuthority.regionDiscoveryMetadata
         );

diff --git a/lib/msal-node/src/client/ClientCredentialClient.ts b/lib/msal-node/src/client/ClientCredentialClient.ts
@@ -229,6 +229,7 @@ export class ClientCredentialClient extends BaseClient {
                 authority.tokenEndpoint,
                 queryParametersString
             );
+
             const requestBody = this.createTokenRequestBody(request);
             const headers: Record<string, string> =
                 this.createTokenRequestHeaders();
@@ -244,6 +245,10 @@ export class ClientCredentialClient extends BaseClient {
                 sshKid: request.sshKid,
             };
 
+            this.logger.info(
+                "Sending token request to endpoint: " + authority.tokenEndpoint
+            );
+
             reqTimestamp = TimeUtils.nowSeconds();
             const response = await this.executePostToTokenEndpoint(
                 endpoint,