Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: route name prefix #116

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: route name prefix #116

merged 1 commit into from
Mar 6, 2025

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Mar 6, 2025 •
edited
Loading

Description

Remove user defined route name prefix

Fixes: #115

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@jaredfholgate jaredfholgate self-assigned this Mar 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 6, 2025
arjenhuitema
arjenhuitema approved these changes Mar 6, 2025
View reviewed changes
Copy link

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 7e5ffa5 into main Mar 6, 2025
18 of 20 checks passed
@jaredfholgate jaredfholgate deleted the fix-user-defined-route-names branch March 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

@matt-FFFFFF matt-FFFFFF Awaiting requested review from matt-FFFFFF

Assignees

@jaredfholgate jaredfholgate

Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for more control over route names
2 participants
@jaredfholgate @arjenhuitema