Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style update #107

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a693461
CmakeList: add some compile options
khancyr Jul 31, 2024
b76b5d8
ArduPilotPlugin.hh: remove unexisting forward declaration
khancyr Jul 31, 2024
ab89928
ArduPilotPlugin.hh: make class final to make clang-tidy happy
khancyr Jul 31, 2024
4acd2eb
ArduPilotPlugin.hh: make destructor default and final to make clang-t…
khancyr Jul 31, 2024
097e629
ArduPilotPlugin.hh: sdf::ElementPtr can be access as const reference
khancyr Jul 31, 2024
00aa219
ArduPilotPlugin.cc: make Control destructor default
khancyr Jul 31, 2024
1e1e837
ArduPilotPlugin.cc: fix static member access from instance
khancyr Jul 31, 2024
8293db4
ArduPilotPlugin.cc: fix ranges variable shadowing
khancyr Jul 31, 2024
46c5d46
ArduPilotPlugin.cc: fix fcu_frame_count implict cast
khancyr Jul 31, 2024
e53c3e2
ArduPilotPlugin.cc: fix unused parameter
khancyr Jul 31, 2024
b2c5158
ArduPilotPlugin.cc: fix implicit fallthrough
khancyr Jul 31, 2024
60b979b
ArduPilotPlugin.cc: fix implicast
khancyr Jul 31, 2024
2c61274
ArduPilotPlugin.cc: fix pkt_frame_count implicit cast
khancyr Jul 31, 2024
b5537b7
ArduPilotPlugin.cc: comment unused variables
khancyr Jul 31, 2024
145bde5
ArduPilotPlugin.cc: zero init variable (clang-tidy check)
khancyr Jul 31, 2024
2e2c252
GstCameraPlugin: fix unused parameter
khancyr Jul 31, 2024
66bd3ee
GstCameraPlugin: correct cast and nullptr usage
khancyr Jul 31, 2024
68362da
CMakeList: Correct compile flags for clang
khancyr Aug 5, 2024
9f09242
ArduPilotPlugin: fix implicit conversion changes signedness: 'int' to…
khancyr Aug 5, 2024
60bc962
ArduPilotPlugin: use ranged base loop
khancyr Aug 5, 2024
4af5cea
ArduPilotPlugin: used lambda instead of bind
khancyr Aug 5, 2024
c5f1916
ArduPilotPlugin: use make_shared to create object
khancyr Aug 5, 2024
8d6727e
ArduPilotPlugin: use std::move to get OnMessageWrapper callback
khancyr Aug 5, 2024
551c0aa
ArduPilotPlugin: fix initial value and import
khancyr Aug 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ArduPilotPlugin: use std::move to get OnMessageWrapper callback
  • Loading branch information
khancyr committed Aug 12, 2024
commit 8d6727ea188d06d26c1d2d1733c46662b74fb55d
4 changes: 2 additions & 2 deletions src/ArduPilotPlugin.cc
Original file line number Diff line number Diff line change
@@ -169,8 +169,8 @@ class OnMessageWrapper
public: callback_t callback;

/// \brief Constructor
public: OnMessageWrapper(const callback_t &_callback)
: callback(_callback)
public: explicit OnMessageWrapper(callback_t _callback)
: callback(std::move(_callback))
{
}