Fix post edit controls appearing on inbox items #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
approved these changes
Apr 29, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit-Rewritten
that referenced
this pull request
Apr 29, 2024
marcustyphoon
added a commit
to marcustyphoon/XKit-Rewritten
that referenced
this pull request
May 3, 2024
I guess this selector should be a util, huh. or actually the whole editable-posts-get-buttons thing should be exported from control_buttons.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick Tags and Trim Reblogs currently detect the "answer" button on items in the inbox as an "edit" button and thus add their control buttons to those items. This doesn't make much sense; Trim Reblogs can't possibly do anything in this case. Quick Tags does function here but it's odd to be able to tag an ask before responding to it (and you have to open the editor to respond to it, at which point you can use Quick Tags in the editor if desired).
This removes this behavior.
Testing steps