-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Tags/Trim Reblogs: Broken in Russian and Hindi #1459
Comments
Probably-exhaustive list of every translated string one cannot rely on only having one localized counterpart per language at time of writing; don't ask why I bothered because I don't know either: (edit: okay it was actually sort of useful for determining how much this actually breaks features, at present)
|
Oh, and for the record, yeah, this is kind of my fault, re: insufficient testing of #1374. But, you know, ehhh. I don't recall whether or not I tested Spanish or not; I don't exactly feel unjustified in not testing every single language. |
Platform
MacOS 14.4.1 arm64
Browser
Chrome 123.0.6312.87
Addon version
master
Details
Same cause as #1424: Tumblr's normalized language data given in
window.tumblr
only gives one result back if an English-language string corresponds to multiple localized strings, so our entiretranslate()
helper is unreliable when used as part of a CSS selector.In this case, in Russian, both Редактировать and Изменить correspond to to
Edit
.Not sure what would be the best way to correct this properly (from both sides). Changing the format of the
languageData
to have multiple values corresponding to one key would be cool, though there would obviously have to be backwards compatibility. In a sense I wish ambiguous values weren't included, but that's silly when you're using it to localize extension UI. We could ignore the helper and parse the non-normalized language data, but that's fragile.Anyway, in the short term we need to target the edit button in a different way.
#managed-icon__edit
should be fine, I imagine.The text was updated successfully, but these errors were encountered: