Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pure annotations class expressions #14

Merged
merged 4 commits into from
Jan 7, 2025
Merged

add support for pure annotations class expressions #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d586f3a
add support for pure annotations class expressions
fubhy Jul 20, 2024
4bd79f4
Update src/index.js
fubhy Jul 20, 2024
ead56a5
Merge remote-tracking branch 'origin/main' into support-class-express…
Andarist Jan 7, 2025
b494d94
tweak tests
Andarist Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const isInAssignmentContext = path => {
do {
;({ parentPath } = parentPath || path)

if (parentPath.isVariableDeclaration() || parentPath.isAssignmentExpression()) {
if (parentPath.isVariableDeclaration() || parentPath.isAssignmentExpression() || parentPath.isClassDeclaration()) {
fubhy marked this conversation as resolved.
Show resolved Hide resolved
return true
}
} while (parentPath !== statement)
Expand Down
8 changes: 8 additions & 0 deletions test/fixtures/annotate/dynamic-extends/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const base = bar =>
class {
foo() {
return bar
}
}

class MyClass extends base() {}
7 changes: 7 additions & 0 deletions test/fixtures/annotate/dynamic-extends/output6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const base = bar => class {
foo() {
return bar;
}
};

class MyClass extends /*#__PURE__*/base() {}
9 changes: 9 additions & 0 deletions test/fixtures/annotate/dynamic-extends/output7.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const base = bar => class {
foo() {
return bar;
}
};

class MyClass extends
/*#__PURE__*/
base() {}
Copy link
Contributor Author

@fubhy fubhy Jul 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just guessed that this would be the output expected by the test suite. But I can't reproduce this formatting with a fresh install of the dependencies here (due to no lock file) :-)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this repo could use some work on setting up github actions instead of Travis, updating deps and just dropping Babel 6 support 😅