add support for pure annotations class expressions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubhy
commented
Jul 20, 2024
Comment on lines
7
to
9
| class MyClass extends | ||
| /*#__PURE__*/ | ||
| base() {} |
There was a problem hiding this comment.
I just guessed that this would be the output expected by the test suite. But I can't reproduce this formatting with a fresh install of the dependencies here (due to no lock file) :-)
There was a problem hiding this comment.
Well, this repo could use some work on setting up github actions instead of Travis, updating deps and just dropping Babel 6 support 😅
Andarist
reviewed
Jul 20, 2024
Co-authored-by: Mateusz Burzyński <[email protected]>
|
Thanks Mateusz! :-) |
|
Better late than never, right? :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a common pattern we use in @effect/schema.
I couldn't get the babel7 tests to pass because the output I get there is identical to the one for babel6 (without the line breaks). Can you guide me to the right babel version that is needed to reproduce that? If necessary? :-)