Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMCAL-565, EMCAL-566]: Differentiate between run type and max time d… #12848

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jokonig
Copy link
Collaborator

@jokonig jokonig commented Mar 12, 2024

…ifference for loading of calib hists

  • Online calibration relies on saving and loading the calibration histograms at the EOR (SOR)
  • However, the old objects should not be loaded if the run type (calib, physics etc.) differes, or if the time difference between the old object and the current data taking is too long
  • Now, the root file storing the objects is named differently, depending on the run type
  • The old timestamp (in hours) is stored in the file itself and then loaded at SOR and compared to the current ts
  • The fill Nr is stored in the file and an option is implemented to only load calibration objects if the fill is the same as for the old object
  • All parameters are configurable in the Calib Params

@jokonig jokonig requested a review from mfasDa as a code owner March 12, 2024 16:46
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@jokonig jokonig changed the title [EMCAL-565, EMCAL-566]: Differentiate between run type and max time d… [WIP] [EMCAL-565, EMCAL-566]: Differentiate between run type and max time d… Mar 12, 2024
@jokonig jokonig changed the title [WIP] [EMCAL-565, EMCAL-566]: Differentiate between run type and max time d… [EMCAL-565, EMCAL-566]: Differentiate between run type and max time d… Mar 13, 2024
mfasDa
mfasDa previously approved these changes Mar 13, 2024
Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfasDa mfasDa enabled auto-merge (squash) March 13, 2024 15:38
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for b28c633 at 2024-03-13 22:05:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/704c8f5e3b3affa6cb787722d27f950c0197b214/slc8_x86-64/o2checkcode/1.0-local218/etc/modulefiles
++ cat
--

Full log here.

…ifference for loading of calib hists

- Online calibration relies on saving and loading the calibration histograms at the EOR (SOR)
- However, the old objects should not be loaded if the run type (calib, physics etc.) differes, or if the time difference between the old object and the current data taking is too long
- Now, the root file storing the objects is named differently, depending on the run type
- The old timestamp (in hours) is stored in the file itself and then loaded at SOR and compared to the current ts
- The fill Nr is stored in the file and an option is implemented to only load calibration objects if the fill is the same as for the old object
- All parameters are configurable in the Calib Params
@mfasDa mfasDa merged commit 501b272 into AliceO2Group:dev Mar 18, 2024
12 checks passed
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…ifference for loading of calib hists (AliceO2Group#12848)

- Online calibration relies on saving and loading the calibration histograms at the EOR (SOR)
- However, the old objects should not be loaded if the run type (calib, physics etc.) differes, or if the time difference between the old object and the current data taking is too long
- Now, the root file storing the objects is named differently, depending on the run type
- The old timestamp (in hours) is stored in the file itself and then loaded at SOR and compared to the current ts
- The fill Nr is stored in the file and an option is implemented to only load calibration objects if the fill is the same as for the old object
- All parameters are configurable in the Calib Params

Co-authored-by: jokonig <[email protected]>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…ifference for loading of calib hists (AliceO2Group#12848)

- Online calibration relies on saving and loading the calibration histograms at the EOR (SOR)
- However, the old objects should not be loaded if the run type (calib, physics etc.) differes, or if the time difference between the old object and the current data taking is too long
- Now, the root file storing the objects is named differently, depending on the run type
- The old timestamp (in hours) is stored in the file itself and then loaded at SOR and compared to the current ts
- The fill Nr is stored in the file and an option is implemented to only load calibration objects if the fill is the same as for the old object
- All parameters are configurable in the Calib Params

Co-authored-by: jokonig <[email protected]>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…ifference for loading of calib hists (AliceO2Group#12848)

- Online calibration relies on saving and loading the calibration histograms at the EOR (SOR)
- However, the old objects should not be loaded if the run type (calib, physics etc.) differes, or if the time difference between the old object and the current data taking is too long
- Now, the root file storing the objects is named differently, depending on the run type
- The old timestamp (in hours) is stored in the file itself and then loaded at SOR and compared to the current ts
- The fill Nr is stored in the file and an option is implemented to only load calibration objects if the fill is the same as for the old object
- All parameters are configurable in the Calib Params

Co-authored-by: jokonig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants