Skip to content

Commit

Permalink
[apps][go][templates] Bump AGP to 7.4.1 (expo#21365)
Browse files Browse the repository at this point in the history
# Why

AGP 7.3 does not support Kotlin 1.8 officially: https://developer.android.com/studio/write/kotlin-support
this seems to be the root cause of proguard issue because some kotlin `Metadata` is be stripped.

# How

bump AGP to 7.4.1

# Test Plan

- ci passed
- android versioned expo go + enable proguard + NCL image
- sdk 48 `expo-template-bare-minimum` app debug build
- sdk 48 `expo-template-bare-minimum` app release build
- sdk 48 `expo-template-bare-minimum` app release build with proguard
  • Loading branch information
Kudo authored Feb 23, 2023
1 parent 1909f89 commit f56dc1b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ buildscript {
dbFlowVersion = '4.2.4'
buildToolsVersion = '33.0.0'
kotlinVersion = '1.8.10'
gradlePluginVersion = '7.3.1'
gradlePluginVersion = '7.4.1'
gradleDownloadTaskVersion = '5.0.1'
repositoryUrl = "file:${System.env.HOME}/.m2/repository/"

Expand Down
2 changes: 1 addition & 1 deletion apps/bare-expo/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import groovy.json.JsonSlurper
buildscript {
ext {
buildToolsVersion = '33.0.0'
gradlePluginVersion = '7.3.1'
gradlePluginVersion = '7.4.1'
minSdkVersion = 21
compileSdkVersion = 33
targetSdkVersion = 33
Expand Down
2 changes: 1 addition & 1 deletion apps/fabric-tester/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath('com.android.tools.build:gradle:7.3.1')
classpath('com.android.tools.build:gradle:7.4.1')
classpath('com.facebook.react:react-native-gradle-plugin')
}
}
Expand Down
2 changes: 1 addition & 1 deletion templates/expo-template-bare-minimum/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath('com.android.tools.build:gradle:7.3.1')
classpath('com.android.tools.build:gradle:7.4.1')
classpath('com.facebook.react:react-native-gradle-plugin')
}
}
Expand Down

0 comments on commit f56dc1b

Please sign in to comment.