Skip to content

Commit

Permalink
[go] fix glide app module kapt issue for expo-image (expo#21355)
Browse files Browse the repository at this point in the history
# Why

close ENG-7642

# How

the kapt generated code for AppGlideModule should cover all versioned LibraryGlideModule. previously we put it inside **expoview**, so it includes the unversioned loaders only. this pr moves the AppGlideModule to **android/app**, so that kapt should able to generate modules from all versioned code.


# Test Plan

versioned expo go + https://github.com/brentvatne/expo-image-go-repro
  • Loading branch information
Kudo authored Feb 23, 2023
1 parent 02927f3 commit 1909f89
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
apply plugin: 'kotlin-kapt'

buildscript {
// Simple helper that allows the root project to override versions declared by this library.
ext.safeExtGet = { prop, fallback ->
Expand Down Expand Up @@ -153,6 +155,10 @@ dependencies {
implementation 'com.squareup.okhttp3:okhttp:3.10.0'
implementation 'com.squareup.okhttp3:okhttp-urlconnection:3.10.0'

// expo-image
def GLIDE_VERSION = "4.13.2"
kapt "com.github.bumptech.glide:compiler:${GLIDE_VERSION}"

// Testing
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
androidTestImplementation 'androidx.test:runner:1.4.0'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package host.exp.exponent.modules
package host.exp.exponent

import android.content.Context
import android.util.Log
Expand Down

0 comments on commit 1909f89

Please sign in to comment.