Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4 add cli support #5

Merged
merged 28 commits into from
Feb 4, 2022
Merged

Issue 4 add cli support #5

merged 28 commits into from
Feb 4, 2022

Conversation

Advik-B
Copy link
Owner

@Advik-B Advik-B commented Feb 4, 2022

As requested by #4

@pep8speaks
Copy link

pep8speaks commented Feb 4, 2022

Hello @Advik-B! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:80: E501 line too long (147 > 79 characters)
Line 10:1: E302 expected 2 blank lines, found 1
Line 29:80: E501 line too long (80 > 79 characters)
Line 35:80: E501 line too long (80 > 79 characters)
Line 36:80: E501 line too long (136 > 79 characters)
Line 79:71: E225 missing whitespace around operator
Line 107:22: E231 missing whitespace after ':'
Line 107:22: E701 multiple statements on one line (colon)
Line 107:23: E225 missing whitespace around operator
Line 152:1: E302 expected 2 blank lines, found 1

Line 27:1: W293 blank line contains whitespace
Line 30:1: W293 blank line contains whitespace
Line 39:80: E501 line too long (91 > 79 characters)
Line 50:80: E501 line too long (83 > 79 characters)
Line 60:1: W293 blank line contains whitespace
Line 65:80: E501 line too long (80 > 79 characters)
Line 71:80: E501 line too long (92 > 79 characters)
Line 75:80: E501 line too long (80 > 79 characters)
Line 78:80: E501 line too long (94 > 79 characters)
Line 81:1: W293 blank line contains whitespace
Line 91:80: E501 line too long (94 > 79 characters)
Line 94:80: E501 line too long (118 > 79 characters)
Line 97:80: E501 line too long (118 > 79 characters)
Line 115:80: E501 line too long (86 > 79 characters)
Line 124:21: E124 closing bracket does not match visual indentation
Line 125:80: E501 line too long (85 > 79 characters)
Line 133:80: E501 line too long (89 > 79 characters)
Line 138:80: E501 line too long (92 > 79 characters)
Line 140:1: W293 blank line contains whitespace
Line 152:80: E501 line too long (112 > 79 characters)
Line 164:25: W292 no newline at end of file

Line 15:1: E302 expected 2 blank lines, found 1
Line 24:1: W293 blank line contains whitespace
Line 27:1: W293 blank line contains whitespace
Line 29:5: E303 too many blank lines (2)
Line 34:80: E501 line too long (91 > 79 characters)
Line 45:80: E501 line too long (83 > 79 characters)
Line 55:1: W293 blank line contains whitespace
Line 60:80: E501 line too long (80 > 79 characters)
Line 66:80: E501 line too long (92 > 79 characters)
Line 70:80: E501 line too long (80 > 79 characters)
Line 73:80: E501 line too long (94 > 79 characters)
Line 76:1: W293 blank line contains whitespace
Line 86:80: E501 line too long (94 > 79 characters)
Line 89:80: E501 line too long (118 > 79 characters)
Line 92:80: E501 line too long (118 > 79 characters)
Line 107:80: E501 line too long (86 > 79 characters)
Line 116:21: E124 closing bracket does not match visual indentation
Line 125:80: E501 line too long (89 > 79 characters)
Line 130:80: E501 line too long (92 > 79 characters)
Line 132:1: W293 blank line contains whitespace
Line 144:80: E501 line too long (112 > 79 characters)
Line 157:1: E302 expected 2 blank lines, found 1
Line 188:1: E304 blank lines found after function decorator
Line 207:80: E501 line too long (80 > 79 characters)
Line 213:1: E305 expected 2 blank lines after class or function definition, found 1

Line 20:1: W293 blank line contains whitespace
Line 23:1: W293 blank line contains whitespace
Line 29:1: W293 blank line contains whitespace
Line 35:9: E251 unexpected spaces around keyword / parameter equals
Line 35:11: E251 unexpected spaces around keyword / parameter equals
Line 36:12: E251 unexpected spaces around keyword / parameter equals
Line 36:14: E251 unexpected spaces around keyword / parameter equals
Line 37:16: E251 unexpected spaces around keyword / parameter equals
Line 37:18: E251 unexpected spaces around keyword / parameter equals
Line 38:12: E251 unexpected spaces around keyword / parameter equals
Line 38:14: E251 unexpected spaces around keyword / parameter equals
Line 38:46: E231 missing whitespace after ','
Line 39:16: E251 unexpected spaces around keyword / parameter equals
Line 39:18: E251 unexpected spaces around keyword / parameter equals

Line 18:1: W293 blank line contains whitespace
Line 21:20: E231 missing whitespace after ':'
Line 26:1: W293 blank line contains whitespace
Line 32:9: E251 unexpected spaces around keyword / parameter equals
Line 32:11: E251 unexpected spaces around keyword / parameter equals
Line 33:12: E251 unexpected spaces around keyword / parameter equals
Line 33:14: E251 unexpected spaces around keyword / parameter equals
Line 34:16: E251 unexpected spaces around keyword / parameter equals
Line 34:18: E251 unexpected spaces around keyword / parameter equals
Line 35:12: E251 unexpected spaces around keyword / parameter equals
Line 35:14: E251 unexpected spaces around keyword / parameter equals
Line 35:46: E231 missing whitespace after ','
Line 36:16: E251 unexpected spaces around keyword / parameter equals
Line 36:18: E251 unexpected spaces around keyword / parameter equals

Line 1:11: E401 multiple imports on one line
Line 5:1: E302 expected 2 blank lines, found 1
Line 34:1: W293 blank line contains whitespace
Line 51:26: W292 no newline at end of file

Comment last updated at 2022-02-04 13:15:43 UTC

Issue 4 add cli support (Sourcery refactored)
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.88%.

Quality metrics Before After Change
Complexity 5.15 ⭐ 5.31 ⭐ 0.16 👎
Method Length 45.24 ⭐ 48.79 ⭐ 3.55 👎
Working memory 8.30 🙂 8.53 🙂 0.23 👎
Quality 71.01% 🙂 70.13% 🙂 -0.88% 👎
Other metrics Before After Change
Lines 47 93 46
Changed files Quality Before Quality After Quality Change
src/logger.py 71.01% 🙂 69.51% 🙂 -1.50% 👎
src/setup.py % 76.12% ⭐ %

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/logger.py Logger.log 7 ⭐ 102.97 🙂 11 😞 59.80% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Advik-B Advik-B merged commit 1b0697e into Master Feb 4, 2022
@lgtm-com
Copy link

lgtm-com bot commented Feb 4, 2022

This pull request introduces 2 alerts when merging 3076590 into 6215794 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Wrong number of arguments in a call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants