Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4 add cli support (Sourcery refactored) #6

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Feb 4, 2022

Pull Request #5 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the issue-4-Add_CLI_support branch, then run:

git fetch origin sourcery/issue-4-Add_CLI_support
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from Advik-B February 4, 2022 13:07
@pep8speaks
Copy link

Hello @sourcery-ai[bot]! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 107:22: E231 missing whitespace after ':'
Line 107:22: E701 multiple statements on one line (colon)
Line 107:23: E225 missing whitespace around operator

Comment on lines -107 to +110
directory = QFileDialog.getExistingDirectory(
if directory := QFileDialog.getExistingDirectory(
self,
caption="Select output directory",
)
if directory:
):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function UI.browse_output_dir refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Feb 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.32%.

Quality metrics Before After Change
Complexity 0.80 ⭐ 0.80 ⭐ 0.00
Method Length 53.55 ⭐ 53.45 ⭐ -0.10 👍
Working memory 8.49 🙂 8.58 🙂 0.09 👎
Quality 73.19% 🙂 72.87% 🙂 -0.32% 👎
Other metrics Before After Change
Lines 152 151 -1
Changed files Quality Before Quality After Quality Change
src/main.py 73.19% 🙂 72.87% 🙂 -0.32% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/main.py UI.__init__ 1 ⭐ 242 ⛔ 15 😞 46.82% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Advik-B Advik-B merged commit 7474d25 into issue-4-Add_CLI_support Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants