[fix] bug where an extra comma is added after final object #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantic
force-pushed
the
bantic/fix-bug-final-delimiter
branch
from
7bebae5 to
9b8c7dd
Compare
bantic
force-pushed
the
bantic/fix-bug-final-delimiter
branch
from
d0ac10c to
e1c54ee
Compare
bantic
changed the title
mixonic
approved these changes
Jan 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #53 introduced a bug when it converted
<EntryViewer>to be a glimmer component and didn't change thethis.isLastreference to@isLast, here: https://github.com/Addepar/ember-json-viewer/pull/53/files#diff-7c6ad1a893bdd5bfc2ea6e617faccaea5a1feb2fd3321c69fd1fbcd933e05144R33That value became permanently false-y and as a result an extraneous comma delimiter is added after a final object.
This can be seen in the deployed docs: