[fix] bug where an extra comma is added after final object (#65)

* Failing test * Fix bug where an extra comma is added after final object
Addepar · Jan 10, 2025 · fd9e28c · fd9e28c
1 parent a6df266
commit fd9e28c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/addon/addon/components/entry-viewer.hbs b/addon/addon/components/entry-viewer.hbs
@@ -30,7 +30,7 @@
     @displayOptions={{@displayOptions}}
     @path={{@path}}
   />
-  {{#unless this.isLast}}
+  {{#unless @isLast}}
     {{! In order for copy/paste to work, there cannot be extra whitespace around the delimiter }}
     <span class="entry-delimiter" data-path={{concat @path "@" ","}}>,</span>
   {{/unless}}

diff --git a/test-app/tests/integration/components/json-viewer-test.js b/test-app/tests/integration/components/json-viewer-test.js
@@ -145,4 +145,23 @@ module('Integration | Component | json-viewer', function (hooks) {
       assert.strictEqual(userSelectStyle, expected);
     }
   });
+
+  test('no comma after final object', async function (assert) {
+    this.set('json', {
+      obj: { foo: 'bar' },
+    });
+    await render(
+      hbs`<JsonViewer data-test-json-viewer-outer @json={{this.json}} />`,
+    );
+
+    assert
+      .dom('[data-path="$.obj>"]')
+      .containsText('}', 'object closing brace is present');
+    assert
+      .dom('[data-path="$.obj@,"]')
+      .doesNotExist('no comma after final object');
+    assert
+      .dom('[data-test-json-viewer-outer]')
+      .doesNotContainText(',', 'No comma appears in the output');
+  });
 });