Bugfix: FWF-3748: Fix keyerror for a user with create_designs and create_submissions on accessing formlist with includeSubmissionsCount=true #2538
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auslin-aot
changed the title
…designer) check for submission count
auslin-aot
force-pushed
the
feature/fwf-3748-submissions-count-client-form-list
branch
from
f228969 to
ce763e3
Compare
|
arun-s-aot
approved these changes
Jan 21, 2025
shuhaib-aot
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Tracking
JIRA:
Issue Type: BUG/ FEATURE
https://aottech.atlassian.net/browse/FWF-3748
Changes
A KeyError on parent_form_id occurs when a user with _create_designs and create_submissions permissions uses the includeSubmissionsCount=true parameter. This happens because parent_form_id is not included in the select query for fetching forms (find_all_forms) for designers but is included for clients. To resolve this, add a showForOnlyCreateSubmissionUsers (ignore designer -> schema name) check before fetching the count.
Screenshots
After fix
Checklist