FWF-3748: [Feature] Included showForOnlyCreateSubmissionUsers(ignore_…

…designer) check for submission count
AOT-Technologies · Jan 21, 2025 · f228969 · f228969
1 parent be2efbc
commit f228969
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/forms-flow-api/src/formsflow_api/resources/form_process_mapper.py b/forms-flow-api/src/formsflow_api/resources/form_process_mapper.py
@@ -321,6 +321,7 @@ def get():  # pylint: disable=too-many-locals
             is_designer=is_designer,
             active_forms=active_forms,
             include_submissions_count=include_submissions_count,
+            ignore_designer=ignore_designer,
         )
         return (
             (

diff --git a/forms-flow-api/src/formsflow_api/services/form_process_mapper.py b/forms-flow-api/src/formsflow_api/services/form_process_mapper.py
@@ -52,6 +52,7 @@ def get_all_forms(  # pylint: disable=too-many-positional-arguments
         is_designer: bool,
         active_forms: bool,
         include_submissions_count: bool,
+        ignore_designer: bool,
         **kwargs,
     ):  # pylint: disable=too-many-arguments, too-many-locals
         """Get all forms."""
@@ -93,7 +94,13 @@ def get_all_forms(  # pylint: disable=too-many-positional-arguments
             )
         mapper_schema = FormProcessMapperSchema()
         mappers_response = mapper_schema.dump(mappers, many=True)
-        if include_submissions_count and CREATE_SUBMISSIONS in user.roles:
+        # Submissions count should return only for user with create_submissions permission
+        # & client form listing with showForOnlyCreateSubmissionUsers param true
+        if (
+            include_submissions_count
+            and CREATE_SUBMISSIONS in user.roles
+            and ignore_designer
+        ):
             current_app.logger.debug("Fetching submissions count..")
             for mapper in mappers_response:
                 mapper["submissionsCount"] = (