Fix a bug when undefined was been tried to convert to an array

0xProject · Nov 13, 2018 · 11f0beb · 11f0beb
1 parent 3fb2904
commit 11f0beb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json
@@ -5,6 +5,10 @@
             {
                 "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks the web3.js websocket RPC provider",
                 "pr": 1227
+            },
+            {
+                "note":
+                    "Fix the bug when order watcher was trying to convert undefined to an object in case of CancelUpTo event"
             }
         ]
     },

diff --git a/packages/order-watcher/src/order_watcher/dependent_order_hashes_tracker.ts b/packages/order-watcher/src/order_watcher/dependent_order_hashes_tracker.ts
@@ -50,7 +50,7 @@ export class DependentOrderHashesTracker {
         return uniqueOrderHashList;
     }
     public getDependentOrderHashesByMaker(makerAddress: string): string[] {
-        const dependentOrderHashes = Array.from(this._orderHashesByMakerAddress[makerAddress]);
+        const dependentOrderHashes = Array.from(this._orderHashesByMakerAddress[makerAddress] || {});
         return dependentOrderHashes;
     }
     public getDependentOrderHashesByAssetDataByMaker(makerAddress: string, assetData: string): string[] {
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,10 @@ @@
                 {
                     "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks the web3.js websocket RPC provider",
                     "pr": 1227
+                },
+                {
+                    "note":
+                        "Fix the bug when order watcher was trying to convert undefined to an object in case of CancelUpTo event"
                 }
             ]
         },
@@ Expand Down @@