Merge pull request #1248 from 0xProject/fixLowercaseAddressBug

Fix lowercase address bug in LedgerSubprovider and MnemonicSubprovider
0xProject · Nov 13, 2018 · 3fb2904 · 3fb2904
2 parents 161a935 + 320460f
commit 3fb2904
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/subproviders/src/subproviders/ledger.ts b/packages/subproviders/src/subproviders/ledger.ts
@@ -32,7 +32,6 @@ const DEFAULT_ADDRESS_SEARCH_LIMIT = 1000;
  */
 export class LedgerSubprovider extends BaseWalletSubprovider {
     // tslint:disable-next-line:no-unused-variable
-    private readonly _nonceLock = new Lock();
     private readonly _connectionLock = new Lock();
     private readonly _networkId: number;
     private _baseDerivationPath: string;

diff --git a/packages/subproviders/src/utils/wallet_utils.ts b/packages/subproviders/src/utils/wallet_utils.ts
@@ -56,10 +56,11 @@ export const walletUtils = {
         parentDerivedKeyInfo: DerivedHDKeyInfo,
         searchLimit: number,
     ): DerivedHDKeyInfo | undefined {
+        const lowercaseAddress = address.toLowerCase();
         let matchedKey: DerivedHDKeyInfo | undefined;
         const derivedKeyIterator = new DerivedHDKeyInfoIterator(parentDerivedKeyInfo, searchLimit);
         for (const key of derivedKeyIterator) {
-            if (key.address === address) {
+            if (key.address === lowercaseAddress) {
                 matchedKey = key;
                 break;
             }