Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cycling through completion suggestions ending in non-word character #3650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Andriamanitra
Copy link
Contributor

The fix is only relevant for certain plugins, but I think this is more correct behavior anyway.

fixes #3649

@matthias314
Copy link
Contributor

I've come across the same issue for the LaTeX plugin I'm working on, and I've come up with the same fix matthias314@f13dc1c. It works well.

@Andriamanitra
Copy link
Contributor Author

I've come across the same issue for the LaTeX plugin I'm working on, and I've come up with the same fix matthias314@f13dc1c. It works well.

Good to know that this patch is not entirely useless to everyone besides me, and that's funny that you came up with the exact same fix! 😄 My first thought was to separate Autocomplete and CycleAutocomplete and change the default binding for Tab to CycleAutocomplete|Autocomplete|Indent|InsertTab. I still think that would be slightly more elegant solution – but it would mess with users' keybindings so I decided against it.

@matthias314
Copy link
Contributor

I think it's better to modify Autocomplete because this problem already arises when starting autocompletion. For example, for my LaTeX plugin, when I press TAB after \ref{, I want to start autocompletion with all labels defined in the file. If one only changed CycleAutocomplete, then that wouldn't work because of the { character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletions ending with non-word characters can only be cycled through with CycleAutocompleteBack
2 participants