Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termwindow: Show cursor only when his X and Y axis is smaller than the window size #3036

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

JoeKar
Copy link
Collaborator

@JoeKar JoeKar commented Nov 23, 2023

This will prevent showing the cursor over the terminal windows own status bar.

Fixes #3034

@JoeKar JoeKar force-pushed the fix/cursor-term-infobar branch from c3f9428 to 8a45f40 Compare November 23, 2023 19:50
@JoeKar JoeKar changed the title termwindow: Show cursor only when his Y axis is smaller than the window heigh termwindow: Show cursor only when his Y axis is smaller than the window height Nov 23, 2023
@JoeKar JoeKar force-pushed the fix/cursor-term-infobar branch from 8a45f40 to 4886c44 Compare November 23, 2023 20:20
@JoeKar JoeKar changed the title termwindow: Show cursor only when his Y axis is smaller than the window height termwindow: Show cursor only when his X and Y axis is smaller than the window size Nov 23, 2023
@JoeKar
Copy link
Collaborator Author

JoeKar commented Nov 23, 2023

Updated again after realizing that the same is reproducible with vsplit and the term at the left tab.

@dustdfg
Copy link
Contributor

dustdfg commented Dec 3, 2023

It seems that it affects any vsplit even without terms....

screen-1701601607
screen-1701601708

I know micro's internal structure bad but let me guess. I think it is because the left pane gets zero size so the right pane think that it is size is size of full window but micro still draws separator... As you can see from two
following screenshots the divider is drawn above actual pane

screen-1701601991

screen-1701602006

@dustdfg
Copy link
Contributor

dustdfg commented Dec 3, 2023

I am not sure I even didn't looked at code of #3069 but it seems so me that it can be related in some way

@JoeKar
Copy link
Collaborator Author

JoeKar commented Dec 3, 2023

In non-term windows it will be solved with @dmaluka's PR (#3069) too. At least I wasn't able to reproduce it any longer.

@dustdfg
Copy link
Contributor

dustdfg commented Dec 3, 2023

At least I wasn't able to reproduce it any longer.

I also couldn't but I just decided to perform stress test and see what will happen if I open more vsplits than width of the terminal. As expected I got the behavior of #3071 but it also smashed all the splits to visually one with self cursor highlighting

screen-1701601708

But it doesn't give anything new

@JoeKar JoeKar merged commit bfc4b1d into zyedidia:master Mar 13, 2024
3 checks passed
@JoeKar JoeKar deleted the fix/cursor-term-infobar branch March 13, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Term is able to highlight it's own title bar when resized
2 participants